Add explicit Enter/Escape keyboard hints to EFG edit popups - #1106
Merged
Conversation
Co-authored-by: rahulsavani <743139+rahulsavani@users.noreply.github.com>
Co-authored-by: rahulsavani <743139+rahulsavani@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
rahulsavani
September 1, 2026 15:28
View session
Member
|
@copilot Ensure the "Linters and coding standards checks" pass. |
Co-authored-by: rahulsavani <743139+rahulsavani@users.noreply.github.com>
Contributor
Author
Addressed in commit |
There was a problem hiding this comment.
Pull request overview
This PR updates Gambit’s EFG GUI edit popups to make existing keyboard accept/cancel behavior (Enter/Escape) explicitly discoverable via on-screen hint text, aligning it with the existing tab-navigation guidance.
Changes:
- Add an Enter/Escape hint line to the Append/Insert move popup’s existing hint text (and normalize punctuation).
- Add a matching Enter/Escape hint under the Outcome editor popup’s payoff grid, using the same subdued styling (gray + slightly smaller font).
Suppressed comments (1)
src/gui/efgtooltip.cc:841
m_hintTextnow includes a second (potentially long) sentence and is translatable. Consider callingWrap(...)to prevent the popup from expanding horizontally and to handle longer translations more gracefully (matching the existingm_errorText->Wrap(FromDIP(260))).
m_hintText->SetForegroundColour(wxSystemSettings::GetColour(wxSYS_COLOUR_GRAYTEXT));
wxFont hintFont = m_hintText->GetFont();
hintFont.SetPointSize(hintFont.GetPointSize() - 1);
m_hintText->SetFont(hintFont);
outerSizer->Add(m_hintText, 0, wxALL, FromDIP(10));
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
rahulsavani
marked this pull request as ready for review
September 1, 2026 17:08
tturocy
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Gambit! Before you submitting or reviewing a pull request, check out our guidelines for contributing.
The person submitting the PR should ensure it has an informative title and update the headers below, before marking the PR as ready for review and assigning reviewers.
Issues closed by this PR
Issue linking is handled automatically.
Description of the changes in this PR
This PR makes keyboard accept/cancel behavior explicit in EFG edit popups, alongside the existing tab-navigation guidance for action entry. The goal is to make non-modal popup controls discoverable without changing interaction semantics.
AppendMovePopup)OutcomeEditorPopup)How to review this PR